Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete button functionality #294

Conversation

thevijayshankersharma
Copy link
Contributor

Description

This pull request fixes the issue where clicking on the trash icon next to a todo item does not remove the corresponding todo item from the list. The problem arises due to the incorrect setting of the data-index attribute on the trash icon, preventing proper identification of the todo item to be removed.

Fixes: #273

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

brave_TJ82NQMMea.online-video-cutter.com.mp4

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy added bug Something isn't working gssoc level2 labels May 19, 2024
@Sulagna-Dutta-Roy Sulagna-Dutta-Roy merged commit 2caa284 into Sulagna-Dutta-Roy:master May 19, 2024
1 check passed
@thevijayshankersharma thevijayshankersharma deleted the delete-button-functionality branch May 20, 2024 00:32
@sanjay-kv sanjay-kv removed the level2 label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Clicking Trash Icon Doesn't Remove Todo Item
3 participants